a-agmon commented on PR #588: URL: https://github.com/apache/iceberg-rust/pull/588#issuecomment-2325251287
Thanks much for the review and comments @liurenjie1024 I refactored the code to be based on `TreeNodeVisitor` now, and all unit tests there. I initially thought that `TreeNodeVisitor` will add an unnecessary layer of complexity but it actually seems to simplify it in some sense. cc @sdd @FANNG1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
