liurenjie1024 commented on code in PR #588: URL: https://github.com/apache/iceberg-rust/pull/588#discussion_r1740552449
########## crates/integrations/datafusion/src/physical_plan/predicate_converter.rs: ########## @@ -0,0 +1,156 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use datafusion::arrow::datatypes::DataType; +use datafusion::logical_expr::{BinaryExpr, Cast, Expr, Operator}; +use datafusion::scalar::ScalarValue; +use iceberg::expr::{Predicate, Reference}; +use iceberg::spec::Datum; +#[derive(Default)] +pub struct PredicateConverter; Review Comment: Why we need this struct? ########## crates/integrations/datafusion/src/physical_plan/predicate_converter.rs: ########## Review Comment: Is there any specific reason we don't use [TreeNodeVisitor](https://docs.rs/datafusion/latest/datafusion/common/tree_node/trait.TreeNodeVisitor.html) to implement this? ########## crates/integrations/datafusion/src/physical_plan/predicate_converter.rs: ########## Review Comment: Also please add some unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
