FANNG1 commented on code in PR #576:
URL: https://github.com/apache/iceberg-rust/pull/576#discussion_r1729685905
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -1293,7 +1293,7 @@ mod tests {
name: "x".to_string(),
transform: Transform::Identity,
source_id: 1,
- partition_id: Some(1000),
+ field_id: Some(1000),
Review Comment:
By the way, I think `add_partition_field` is more general to use, seems
`add_unbound_field` should only be used in test to specify partition field id,
we should remove `pub ` from `add_unbound_field`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
