Xuanwo commented on code in PR #576:
URL: https://github.com/apache/iceberg-rust/pull/576#discussion_r1729151672


##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -1293,7 +1293,7 @@ mod tests {
                 name: "x".to_string(),
                 transform: Transform::Identity,
                 source_id: 1,
-                partition_id: Some(1000),
+                field_id: Some(1000),

Review Comment:
   I'm a bit surprised that the test against 
`testdata/table_metadata/TableMetadataV2Valid.json` passed before. Would you 
like to conduct a deep investigation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to