nastra commented on code in PR #10953:
URL: https://github.com/apache/iceberg/pull/10953#discussion_r1726803463
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactory.java:
##########
@@ -244,6 +248,18 @@ public final boolean getBoolean(int rowId) {
}
}
+ private static class NullAccessor<
+ DecimalT, Utf8StringT, ArrayT, ChildVectorT extends AutoCloseable>
+ extends ArrowVectorAccessor<DecimalT, Utf8StringT, ArrayT, ChildVectorT>
{
+
+ private final NullVector vector;
Review Comment:
I don't think we need to track this here separately, since the super class
already has a `vector`
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactory.java:
##########
@@ -244,6 +248,18 @@ public final boolean getBoolean(int rowId) {
}
}
+ private static class NullAccessor<
+ DecimalT, Utf8StringT, ArrayT, ChildVectorT extends AutoCloseable>
+ extends ArrowVectorAccessor<DecimalT, Utf8StringT, ArrayT, ChildVectorT>
{
+
+ private final NullVector vector;
+
+ NullAccessor(NullVector vector) {
+ super(vector);
+ this.vector = vector;
Review Comment:
can be removed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
