nastra commented on code in PR #10953:
URL: https://github.com/apache/iceberg/pull/10953#discussion_r1726800757
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactory.java:
##########
@@ -220,8 +221,11 @@ private ArrowVectorAccessor<DecimalT, Utf8StringT, ArrayT,
ChildVectorT> getPlai
}
return new FixedSizeBinaryAccessor<>(
(FixedSizeBinaryVector) vector, stringFactorySupplier.get());
+ } else if (vector instanceof NullVector) {
+ return new NullAccessor<>((NullVector) vector);
}
- throw new UnsupportedOperationException("Unsupported vector: " +
vector.getClass());
+ String vectorName = (vector == null) ? "null" :
vector.getClass().toString();
Review Comment:
rather than having this code I'd probably just add a
`Preconditions.checkArgument(null != vector, "Invalid field vector: null")` at
the beginning of this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
