amogh-jahagirdar commented on code in PR #10872:
URL: https://github.com/apache/iceberg/pull/10872#discussion_r1726207335


##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -174,7 +176,7 @@ DelegateFileIO io(String location) {
     return ioInstances.computeIfAbsent(
         impl,
         key -> {
-          Configuration conf = hadoopConf.get();
+          Configuration conf = getConf();

Review Comment:
   I double checked that the CatalogUtil.loadFileIO calls below are null 
protected as well, the s3fileIO test will exercise that API so that gives 
confidence too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to