nastra commented on PR #10872: URL: https://github.com/apache/iceberg/pull/10872#issuecomment-2296845324
> @nastra Thank you for the review, please let me know if I should moved the `null` check to `getConf` or should we create new `Configuration` if not set? @munendrasn yes I think it makes sense to move the null handling code into `getConf`(see also my other [comment](https://github.com/apache/iceberg/pull/10872#discussion_r1718224622) on this) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
