Kontinuation commented on code in PR #10981:
URL: https://github.com/apache/iceberg/pull/10981#discussion_r1724130005


##########
format/spec.md:
##########
@@ -373,6 +378,13 @@ Notes:
 3. Strings are truncated to a valid UTF-8 string with no more than `L` code 
points.
 4. In contrast to strings, binary values do not have an assumed encoding and 
are truncated to `L` bytes.
 
+#### XZ2 Transform Details
+
+XZ2 is based on the paper [XZ-Ordering: A Space-Filling Curve for Objects with 
Spatial Extensions].
+
+Notes:
+1. Resolution must be a positive integer.  Defaults to TODO

Review Comment:
   GeoMesa uses a high XZ2 resolution when working with key-value stores such 
as Accumulo and HBase, it is not appropriate to always use a resolution that 
high for partitioning data (for instance, [GeoMesa on 
FileSystems](https://www.geomesa.org/documentation/stable/user/filesystem/partition_schemes.html)).
   
   XZ2 resolution 11~12 works for city-scale data, but will generate too many 
partitions for country-scale or world-scale data. I'd like to have a smaller 
default value such as 7 to be safe on various kinds of data.
   
   
[![image](https://github.com/user-attachments/assets/c427bd18-751f-4503-b056-0c6a9dcf8317)](https://www.researchgate.net/publication/376632924_GeoLake_Bringing_Geospatial_Support_to_Lakehouses)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to