sdd commented on code in PR #512: URL: https://github.com/apache/iceberg-rust/pull/512#discussion_r1715808031
########## crates/iceberg/src/spec/manifest.rs: ########## @@ -94,6 +94,12 @@ impl Manifest { &self.entries } + /// Consume this Manifest, returning its constituent parts + pub fn consume(self) -> (Vec<ManifestEntryRef>, ManifestMetadata) { Review Comment: This change was no longer present in this PR after it got rebased, but I've renamed it anyway for consistency with the rest of the codebase. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org