sdd commented on code in PR #512: URL: https://github.com/apache/iceberg-rust/pull/512#discussion_r1712265470
########## crates/iceberg/src/spec/manifest_list.rs: ########## @@ -78,6 +78,11 @@ impl ManifestList { pub fn entries(&self) -> &[ManifestFile] { &self.entries } + + /// Take ownership of the entries in the manifest list, consuming it + pub fn consume_entries(self) -> impl IntoIterator<Item = ManifestFile> { Review Comment: Oh that's nicer. Will do in another PR now that this change was eliminated from this PR in the rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org