sungwy commented on code in PR #1016:
URL: https://github.com/apache/iceberg-python/pull/1016#discussion_r1711386006


##########
mkdocs/docs/configuration.md:
##########
@@ -32,6 +32,7 @@ Iceberg tables support table properties to configure table 
behavior.
 | -------------------------------------- | --------------------------------- | 
------- | 
-------------------------------------------------------------------------------------------
 |
 | `write.parquet.compression-codec`      | `{uncompressed,zstd,gzip,snappy}` | 
zstd    | Sets the Parquet compression coddec.                                  
                      |
 | `write.parquet.compression-level`      | Integer                           | 
null    | Parquet compression level for the codec. If not set, it is up to 
PyIceberg                  |
+| `write.parquet.row-group-limit`        | Number of rows                    | 
1048576 | The upper bound of the number of entries within a single row group    
                      |

Review Comment:
   Thank you for flagging this @zhongyujiang - I'll get the second one below 
with the older default value removed.
   
   To my understanding the new value is the correct default value that matches 
the default in the PyArrow ParquetWriter: 
https://arrow.apache.org/docs/python/generated/pyarrow.parquet.ParquetWriter.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to