nastra commented on code in PR #10861:
URL: https://github.com/apache/iceberg/pull/10861#discussion_r1709540497
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1020,8 +1020,11 @@ public Builder upgradeFormatVersion(int
newFormatVersion) {
return this;
}
- this.formatVersion = newFormatVersion;
- changes.add(new MetadataUpdate.UpgradeFormatVersion(newFormatVersion));
+ // register incremental version changes separately to ensure all upgrade
requirements are met.
+ // formatVersion will be equivalent to newFormatVersion after the loop
completes
+ do {
Review Comment:
actually I think reading this is more complicated than the earlier versions,
especially because it's kind of hidden that `this.formatVersion` is being set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
