leangjonathan commented on code in PR #10861:
URL: https://github.com/apache/iceberg/pull/10861#discussion_r1707652177
##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -1451,50 +1457,67 @@ public void testCreateV2MetadataThroughTableProperty() {
.doesNotContainKey(TableProperties.FORMAT_VERSION);
}
- @Test
- public void testReplaceV1MetadataToV2ThroughTableProperty() {
+ private static Stream<Arguments> upgradeTableVersionProvider() {
+ // return a stream of all valid upgrade paths
+ return IntStream.range(1, TableMetadata.SUPPORTED_TABLE_FORMAT_VERSION)
+ .boxed()
+ .flatMap(
+ baseTableVersion ->
+ IntStream.rangeClosed(
+ baseTableVersion + 1,
TableMetadata.SUPPORTED_TABLE_FORMAT_VERSION)
+ .mapToObj(newTableVersion -> arguments(baseTableVersion,
newTableVersion)));
+ }
+
+ @ParameterizedTest
+ @MethodSource("upgradeTableVersionProvider")
+ public void testReplaceMetadataThroughTableProperty(int baseTableVersion,
int newTableVersion) {
Review Comment:
Thanks for catching that. Made the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
