Fokko commented on code in PR #994: URL: https://github.com/apache/iceberg-python/pull/994#discussion_r1709223886
########## pyiceberg/expressions/parser.py: ########## @@ -84,6 +85,14 @@ @column.set_parse_action def _(result: ParseResults) -> Reference: + if len(result.column) > 1: + deprecation_message( + deprecated_in="0.8.0", + removed_in="0.9.0", + help_message="Parsing expressions with table name is deprecated. Only provide field names in the row_filter.", + ) + # TODO: Once this is removed, we will no longer take just the last index of parsed column result + # And introduce support for parsing filter expressions with nested fields. Review Comment: I came here to point this out indeed. Seems to fail on several levels; I don't think this was ever properly tested.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
