sungwy commented on code in PR #994:
URL: https://github.com/apache/iceberg-python/pull/994#discussion_r1704242416
##########
pyiceberg/catalog/__init__.py:
##########
@@ -613,6 +613,11 @@ def update_namespace_properties(
ValueError: If removals and updates have overlapping keys.
"""
+ @deprecated(
Review Comment:
This deprecates the public function
##########
pyiceberg/catalog/__init__.py:
##########
@@ -627,6 +632,25 @@ def identifier_to_tuple_without_catalog(self, identifier:
Union[str, Identifier]
identifier_tuple = identifier_tuple[1:]
return identifier_tuple
+ def _identifier_to_tuple_without_catalog(self, identifier: Union[str,
Identifier]) -> Identifier:
Review Comment:
where as this is now called by the PyIceberg functions and only prints the
deprecation warning message if we are using the unsupported naming convention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
