stevenzwu commented on code in PR #10859:
URL: https://github.com/apache/iceberg/pull/10859#discussion_r1706343923
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/FlinkWriteOptions.java:
##########
@@ -60,6 +61,14 @@ private FlinkWriteOptions() {}
public static final ConfigOption<String> DISTRIBUTION_MODE =
ConfigOptions.key("distribution-mode").stringType().noDefaultValue();
+ public static final ConfigOption<String> RANGE_DISTRIBUTION_STATISTICS_TYPE =
+ ConfigOptions.key("range-distribution-statistics-type")
+ .stringType()
+ .defaultValue(StatisticsType.Auto.name());
+
+ public static final ConfigOption<Double> CLOSE_FILE_COST_WEIGHT_PERCENTAGE =
+
ConfigOptions.key("close-file-cost-weight-percentage").doubleType().defaultValue(0.02d);
Review Comment:
Yes, `0.02d` meant `2%`. I didn't go with the `percentage` in the naming and
integer as value in order to get a bit more flexibility like maybe like
`0.005d` for `0.5%`.
agree with the comment on naming that is probably not the best. maybe
`close-file-cost-weight`. In the doc, we already explained `0.02d` meant `2%`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
