pvary commented on code in PR #10859:
URL: https://github.com/apache/iceberg/pull/10859#discussion_r1705245091
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/FlinkWriteOptions.java:
##########
@@ -60,6 +61,14 @@ private FlinkWriteOptions() {}
public static final ConfigOption<String> DISTRIBUTION_MODE =
ConfigOptions.key("distribution-mode").stringType().noDefaultValue();
+ public static final ConfigOption<String> RANGE_DISTRIBUTION_STATISTICS_TYPE =
+ ConfigOptions.key("range-distribution-statistics-type")
+ .stringType()
+ .defaultValue(StatisticsType.Auto.name());
+
+ public static final ConfigOption<Double> CLOSE_FILE_COST_WEIGHT_PERCENTAGE =
+
ConfigOptions.key("close-file-cost-weight-percentage").doubleType().defaultValue(0.02d);
Review Comment:
Also keeps open 50 writers (which means high memory footprint).
Does `0.02d` mean 2 percent? In this case we can use
`close-file-cost-weight`.
Or alternatively if `percentage` is in the name, then the value should be `2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
