leangjonathan commented on code in PR #10861:
URL: https://github.com/apache/iceberg/pull/10861#discussion_r1705919014
##########
core/src/test/java/org/apache/iceberg/TestUpdateRequirements.java:
##########
@@ -198,11 +201,26 @@ public void upgradeFormatVersion() {
assertTableUUID(requirements);
}
+ @ParameterizedTest
+ @ValueSource(ints = {2, 3})
+ public void upgradeFormatVersionForView(int formatVersion) {
+ List<UpdateRequirement> requirements =
+ UpdateRequirements.forReplaceView(
+ viewMetadata, ImmutableList.of(new
MetadataUpdate.UpgradeFormatVersion(formatVersion)));
+ requirements.forEach(req -> req.validate(viewMetadata));
+
+ assertThat(requirements)
+ .hasSize(1)
+ .hasOnlyElementsOfType(UpdateRequirement.AssertViewUUID.class);
+
+ assertViewUUID(requirements);
+ }
+
@Test
- public void upgradeFormatVersionForView() {
+ public void upgradeFormatVersionForViewV3() {
Review Comment:
Missed that one. Removing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
