leangjonathan commented on code in PR #10861: URL: https://github.com/apache/iceberg/pull/10861#discussion_r1705911975
########## core/src/test/java/org/apache/iceberg/TestFormatVersions.java: ########## @@ -23,56 +23,100 @@ import java.util.Arrays; import java.util.List; +import java.util.stream.Collectors; +import java.util.stream.IntStream; import org.junit.jupiter.api.TestTemplate; public class TestFormatVersions extends TestBase { @Parameters(name = "formatVersion = {0}") protected static List<Object> parameters() { - return Arrays.asList(1); + return Arrays.asList(1, 2); } @TestTemplate - public void testDefaultFormatVersion() { - assertThat(table.ops().current().formatVersion()).isEqualTo(1); + public void testFormatVersionUpgrade() { + TableOperations ops = table.ops(); + TableMetadata base = ops.current(); + int baseTableVersion = base.formatVersion(); Review Comment: Purging base -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org