munendrasn commented on PR #10873: URL: https://github.com/apache/iceberg/pull/10873#issuecomment-2268991600
Thank you @nastra, for sharing the PR. The inspiration for the current PR is both https://github.com/apache/iceberg/pull/10722 and https://github.com/apache/iceberg/pull/10576 (asked to add expiry property in separate PR). As mentioned [#10722](https://github.com/apache/iceberg/pull/10722/files#diff-ffc6f59bffb61af69bc4ef19c7b28c9fefe015b2716b35db1deb6a5a884ca4feR1200), the preference would be given to config then credential for backward compatibility. There are some exists REST impl returning custom property for expiry in config, hence, raised the PR so that those impl can rely on property from spec... & both config & credentials are aligned in terms of credential related properties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
