munendrasn commented on code in PR #10873: URL: https://github.com/apache/iceberg/pull/10873#discussion_r1703897063
########## open-api/rest-catalog-open-api.py: ########## @@ -1112,6 +1112,7 @@ class LoadTableResult(BaseModel): - `s3.secret-access-key`: secret for credentials that provide access to data in S3 - `s3.session-token`: if present, this value should be used for as the session token - `s3.remote-signing-enabled`: if `true` remote signing should be performed as described in the `s3-signer-open-api.yaml` specification + - `expires-at-ms`: if present, specifies timestamp in milliseconds when credentials would expire Review Comment: yes, once spec is updated.. ie, property name is aligned... planning to add this property. This would help any REST spec impl to have custom refresh mechanism until REST client supports refresh and eventually support refresh mechanism for table credentials too like catalog auth refresh. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org