epgif commented on PR #9008: URL: https://github.com/apache/iceberg/pull/9008#issuecomment-2260512986
@rdblue I will address all your comments, but all but ONE of them are purely internal implementation details. Can we agree that it is safe to address those after merging this? The other one is https://github.com/apache/iceberg/pull/9008/files/d34daad3682e3cd1db87183c0579087eef748ad2#r1697460829 "I don't think that we want to implement this conversion" -- I will push a change for this today. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
