sl255051 commented on code in PR #10678:
URL: https://github.com/apache/iceberg/pull/10678#discussion_r1696124760
##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -390,7 +391,8 @@ Builder checkConflicts(boolean check) {
}
private void checkAndAddPartitionName(String name, Integer sourceColumnId)
{
- Types.NestedField schemaField = schema.findField(name);
+ Types.NestedField schemaField =
Review Comment:
I already investigated this and the answer is I don't believe so.
`findSourceColumn` will throw an exception if the column isn't found whereas
`checkAndAddPartitionName` can still succeed even if the column isn't found.
(See line 400/402)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
