pvary commented on code in PR #10748:
URL: https://github.com/apache/iceberg/pull/10748#discussion_r1693056921
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkSourceConfig.java:
##########
@@ -49,11 +48,11 @@ public void testFlinkHintConfig() {
@TestTemplate
public void testReadOptionHierarchy() {
- // TODO: FLIP-27 source doesn't implement limit pushdown yet
- assumeThat(useFlip27Source).isFalse();
-
getTableEnv().getConfig().set(FlinkReadOptions.LIMIT_OPTION, 1L);
List<Row> result = sql("SELECT * FROM %s", TABLE);
+ // Note that this query doesn't have the limit clause in the SQL.
+ // This assertions works because limit is pushed down to the reader and
+ // reader parallelism is 1.
Review Comment:
Is the limit applied for every reader? Would it mean that if we have 4
readers, and 4 splits, then we will have 4 records in the result instead of 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
