stevenzwu commented on code in PR #10748:
URL: https://github.com/apache/iceberg/pull/10748#discussion_r1690136366
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/reader/RowDataReaderFunction.java:
##########
@@ -61,19 +86,30 @@ public RowDataReaderFunction(
this.io = io;
this.encryption = encryption;
this.filters = filters;
+ this.limit = limit;
}
@Override
public DataIterator<RowData> createDataIterator(IcebergSourceSplit split) {
- return new DataIterator<>(
+ return new LimitableDataIterator<>(
Review Comment:
limit is applied after the residual filters. Residual filters are applied
inside `RowDataFileScanTaskReader`, which is used and wrapped by the
`DataIterator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
