adutra commented on code in PR #10753:
URL: https://github.com/apache/iceberg/pull/10753#discussion_r1688066845
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -81,14 +71,12 @@ public abstract class S3V4RestSignerClient
private static final String SCOPE = "sign";
@SuppressWarnings("immutables:incompat")
- private static volatile ScheduledExecutorService tokenRefreshExecutor;
+ // FIXME auth manager is not properly closed
Review Comment:
Not new to this PR; the executor wasn't being closed either. I think ideally
this component should share the same REST client and the same Auth Manager as
the catalog, but that's far from trivial to implement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
