ajantha-bhat commented on code in PR #10753:
URL: https://github.com/apache/iceberg/pull/10753#discussion_r1688068500
##########
.palantir/revapi.yml:
##########
@@ -1056,6 +1056,9 @@ acceptedBreaks:
- code: "java.method.removed"
old: "method org.apache.iceberg.DataFiles.Builder
org.apache.iceberg.DataFiles.Builder::withEqualityFieldIds(java.util.List<java.lang.Integer>)"
justification: "Deprecations for 1.6.0 release"
+ - code: "java.method.removed"
Review Comment:
I think we can try this
1. Merge https://github.com/apache/iceberg/pull/10754
2. Remove the current addition in the file `revapi.yml` as it is under 1.5.0
3. freshly run `revapiAcceptBreak`, so it will add it under 1.6.0
If this doesn't work. We need to debug why old version is coming as `none`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
