nastra commented on code in PR #10722:
URL: https://github.com/apache/iceberg/pull/10722#discussion_r1684548371
##########
open-api/rest-catalog-open-api.py:
##########
@@ -441,6 +441,30 @@ class AssertViewUUID(BaseModel):
uuid: str
+class AzureCredentials(BaseModel):
+ account_name: Optional[str] = Field(None, alias='account-name')
+ account_key: Optional[str] = Field(None, alias='account-key')
+ token: Optional[str] = None
+
+
+class AwsCredentials(BaseModel):
+ access_key_id: str = Field(..., alias='access-key-id')
+ secret_access_key: str = Field(..., alias='secret-access-key')
+ token: Optional[str] = None
+ expires_at_ms: Optional[int] = Field(None, alias='expires-at-ms')
+
+
+class GcsCredentials(BaseModel):
+ token: str
+ expires_at_ms: Optional[int] = Field(None, alias='expires-at-ms')
+
Review Comment:
I don't think we want to include those, because we only want to standardize
the credentials themselves and bucket / endpoint isn't credential-related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
