nastra commented on code in PR #10722:
URL: https://github.com/apache/iceberg/pull/10722#discussion_r1684546941
##########
open-api/rest-catalog-open-api.py:
##########
@@ -441,6 +441,30 @@ class AssertViewUUID(BaseModel):
uuid: str
+class AzureCredentials(BaseModel):
+ account_name: Optional[str] = Field(None, alias='account-name')
+ account_key: Optional[str] = Field(None, alias='account-key')
+ token: Optional[str] = None
+
+
+class AwsCredentials(BaseModel):
+ access_key_id: str = Field(..., alias='access-key-id')
+ secret_access_key: str = Field(..., alias='secret-access-key')
+ token: Optional[str] = None
+ expires_at_ms: Optional[int] = Field(None, alias='expires-at-ms')
+
Review Comment:
`region` / `endpoint` isn't really credential-related so I don't think these
should be included here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
