Fokko commented on code in PR #108: URL: https://github.com/apache/iceberg-go/pull/108#discussion_r1684492992
########## table/metadata.go: ########## @@ -156,6 +166,42 @@ type commonMetadata struct { Refs map[string]SnapshotRef `json:"refs"` } +func (c *commonMetadata) Equals(other *commonMetadata) bool { Review Comment: For example here: https://github.com/apache/iceberg-python/blob/4282d2f342167255bb65034a12131ce8fe6a9c04/pyiceberg/table/metadata.py#L377-L393 If `schemas` is missing, we'll move the schema in `schema` to `schemas`, and set `current-schema-id`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org