tomtongue commented on code in PR #10684:
URL: https://github.com/apache/iceberg/pull/10684#discussion_r1680239368
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -110,6 +113,14 @@ protected Schema schema() {
return TestFixtures.SCHEMA;
}
+ protected HadoopTableExtension getSourceTableExtension() {
Review Comment:
This is for the inherited class
`TestIcebergSourceFailoverWithWatermarkExtractor`. Specifically this is for the
tests in this class to use its own `SOURCE_TABLE_EXTENSION` and
`SINK_TABLE_EXTENSION` constants. by default, the two constants in the original
class `TestIcebergSourceFailover` are used in
`TestIcebergSourceFailoverWithWatermarkExtractor` tests.
But I feel the same like your comment. Let me change this part to non-use of
these methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
