nastra commented on code in PR #10684:
URL: https://github.com/apache/iceberg/pull/10684#discussion_r1679057314
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -110,6 +113,14 @@ protected Schema schema() {
return TestFixtures.SCHEMA;
}
+ protected HadoopTableExtension getSourceTableExtension() {
Review Comment:
why are these needed? we typically don't add such methods to tests. Also if
this needs to be accessed, then the constant can be accessed directly as it has
the same visibility as this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
