rdblue commented on code in PR #10691:
URL: https://github.com/apache/iceberg/pull/10691#discussion_r1677181515
##########
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##########
@@ -126,6 +141,7 @@ private boolean checkTasks() {
} catch (InterruptedException e) {
throw new RuntimeException("Interrupted while running parallel
task", e);
}
+ continuation.ifPresent(yieldedTasks::addLast);
Review Comment:
Why call this outside of the `try` block? That block only handles
`ExecutionException` and `InterruptedException` so it seems safe to call this
inside and not need to separate the logic into 3 places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
