syun64 commented on code in PR #910: URL: https://github.com/apache/iceberg-python/pull/910#discussion_r1674913965
########## tests/io/test_pyarrow.py: ########## @@ -1798,3 +1799,35 @@ def test_identity_partition_on_multi_columns() -> None: ("n_legs", "ascending"), ("animal", "ascending"), ]) == arrow_table.sort_by([("born_year", "ascending"), ("n_legs", "ascending"), ("animal", "ascending")]) + + +def test_to_requested_schema_timestamps( Review Comment: I've made the function private on this PR, and have another one up to port back to public API function with the previous signature with a deprecation notice here: https://github.com/apache/iceberg-python/pull/918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org