HonahX commented on code in PR #910:
URL: https://github.com/apache/iceberg-python/pull/910#discussion_r1674879351
##########
tests/io/test_pyarrow.py:
##########
@@ -1798,3 +1799,35 @@ def test_identity_partition_on_multi_columns() -> None:
("n_legs", "ascending"),
("animal", "ascending"),
]) == arrow_table.sort_by([("born_year", "ascending"), ("n_legs",
"ascending"), ("animal", "ascending")])
+
+
+def test_to_requested_schema_timestamps(
Review Comment:
+1 on making `to_requested_schema` private. IMO this seem to be specific to
our internal workflow so making it private can give us more flexibility in
future development.
Actually, the signature of this API has been updated in
https://github.com/apache/iceberg-python/pull/786: `pa.Table` to
`pa.RecordBatch`, which is a breaking change. I think it may be a good time to
send a deprecation notice on the old one and making the new one private. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
