danielcweeks commented on code in PR #10603:
URL: https://github.com/apache/iceberg/pull/10603#discussion_r1672685347


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -134,9 +134,17 @@ paths:
     post:
       tags:
         - OAuth2 API
-      summary: Get a token using an OAuth2 flow
+      summary: Get a token using an OAuth2 flow (DEPRECATED for REMOVAL)
+      deprecated: true
       operationId: getToken
       description:
+        The `oauth/tokens` endpoint is **DEPRECATED for REMOVAL**. It is _not_ 
recommended to

Review Comment:
   @snazy I think the discussion above was generally agreed to set the removal 
target at 2.0 and the reason I say that is the [description contains aspect of 
the client 
behavior](https://github.com/apache/iceberg/pull/10603/files#diff-02549ca620d020dc9ead80088cc14e311e12a69651fa8d394cd41a4308debb2eR156-R185),
 so removing that prior to 2.0 would lose that context.
   
   I don't think there's any harm in leaving this until 2.0 for removal as 
we've clearly covered the concerns in the notice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to