danielcweeks commented on code in PR #10603:
URL: https://github.com/apache/iceberg/pull/10603#discussion_r1669603688
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -134,9 +134,17 @@ paths:
post:
tags:
- OAuth2 API
- summary: Get a token using an OAuth2 flow
+ summary: Get a token using an OAuth2 flow (DEPRECATED for REMOVAL)
+ deprecated: true
operationId: getToken
description:
+ The `oauth/tokens` endpoint is **DEPRECATED for REMOVAL**. It is _not_
recommended to
Review Comment:
I think the target version should be tied to the reference implementation
where the default behaviors will change.
As we discussed before, we can change the requirement that URI be set with
the 1.7 release. However, we can't change the behaviors until 2.0. So I think
we should reference the 2.0 release as the target for removal.
In general, we shouldn't add deprecations that don't clearly indicate a
target for removal and reference to the replacement. In this case we don't
have clarity on the exact replacement but I think the current reference to the
issue is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
