jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1672611800
########## open-api/rest-catalog-open-api.yaml: ########## @@ -3647,6 +3786,173 @@ components: type: integer description: "List of equality field IDs" + PreplanTableRequest: + type: object + required: + - table-scan-context + properties: + table-scan-context: + $ref: '#/components/schemas/TableScanContext' + + PlanTableRequest: + type: object + required: + - table-scan-context + properties: + table-scan-context: + $ref: '#/components/schemas/TableScanContext' + plan-task: + $ref: '#/components/schemas/PlanTask' + stats-fields: + description: + A list of fields that the client requests the server to send statistics + in each `FileScanTask` returned in the response + type: array + items: + $ref: '#/components/schemas/FieldName' + + TableScanContext: + anyOf: Review Comment: I was mainly following how the `TableUpdate` and `BaseUpdate` are written right now: ```yaml TableUpdate: anyOf: - $ref: '#/components/schemas/AssignUUIDUpdate' - $ref: '#/components/schemas/UpgradeFormatVersionUpdate' - $ref: '#/components/schemas/AddSchemaUpdate' ... ``` ```yaml BaseUpdate: discriminator: propertyName: action mapping: assign-uuid: '#/components/schemas/AssignUUIDUpdate' upgrade-format-version: '#/components/schemas/UpgradeFormatVersionUpdate' ... ``` Is that a difference case from the one here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org