soumya-ghosh commented on code in PR #900:
URL: https://github.com/apache/iceberg-python/pull/900#discussion_r1669055951


##########
tests/utils/test_manifest.py:
##########
@@ -66,7 +66,7 @@ def test_read_manifest_entry(generated_manifest_entry_file: 
str) -> None:
 
     assert manifest_entry.status == ManifestEntryStatus.ADDED

Review Comment:
   I think this is already getting validated in 
[here](https://github.com/apache/iceberg-python/pull/900/files#diff-9a5a57e7ec723cc4ab6056ce1921f291a501158322d2e6ebf817d568c9621f4bL187).
   At the end of the test we are comparing the contents of avro file with the 
expected `ManifestEntry` object.
   Please correct me if my understanding is wrong.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to