kevinjqliu commented on code in PR #900:
URL: https://github.com/apache/iceberg-python/pull/900#discussion_r1668994905
##########
pyiceberg/manifest.py:
##########
@@ -762,10 +762,10 @@ def add_entry(self, entry: ManifestEntry) ->
ManifestWriter:
if (
(entry.status == ManifestEntryStatus.ADDED or entry.status ==
ManifestEntryStatus.EXISTING)
- and entry.data_sequence_number is not None
- and (self._min_data_sequence_number is None or
entry.data_sequence_number < self._min_data_sequence_number)
+ and entry.sequence_number is not None
+ and (self._min_data_sequence_number is None or
entry.sequence_number < self._min_data_sequence_number)
Review Comment:
i think standardizing them would make it easier to associate the two
variables in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
