liurenjie1024 commented on code in PR #428:
URL: https://github.com/apache/iceberg-rust/pull/428#discussion_r1666803055
##########
Cargo.toml:
##########
@@ -82,6 +82,7 @@ serde_repr = "0.1.16"
serde_with = "3.4.0"
tempfile = "3.8"
tokio = { version = "1", features = ["macros"] }
+tokio-shared-rt = "0.1.0"
Review Comment:
I also have concern about `tokio_shared_rt` for the reasons @Xuanwo
mentioned. Also, the possibility of starting docker compose multi times still
not resolved. As a simpler approach, we can [this
crate](https://docs.rs/ctor/latest/ctor/index.html) to have a constructor to
start docker compose, and a destructor to stop docker compose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
