Xuanwo commented on code in PR #428:
URL: https://github.com/apache/iceberg-rust/pull/428#discussion_r1666177869
##########
Cargo.toml:
##########
@@ -82,6 +82,7 @@ serde_repr = "0.1.16"
serde_with = "3.4.0"
tempfile = "3.8"
tokio = { version = "1", features = ["macros"] }
+tokio-shared-rt = "0.1.0"
Review Comment:
Hi, I'm a bit nervous about introducing `tokio-shared-rt`. It's inactive and
rarely used. Additionally, it might unexpectedly lead developers to share
tests, which goes against our usual rust test pattern.
If we do want this, I will encourage to write our own test harness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
