thexiay commented on code in PR #435:
URL: https://github.com/apache/iceberg-rust/pull/435#discussion_r1666126704
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -123,9 +122,9 @@ impl NamespaceIdent {
Self::from_vec(iter.into_iter().map(|s| s.to_string()).collect())
}
- /// Returns url encoded format.
- pub fn encode_in_url(&self) -> String {
- encode(&self.as_ref().join("\u{1F}")).to_string()
+ /// Returns a string for used in url.
+ pub fn to_url_string(&self) -> String {
+ self.as_ref().join("\u{001f}")
Review Comment:
why here use `\u{001f}`, does it has some special meaning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
