liurenjie1024 commented on code in PR #435:
URL: https://github.com/apache/iceberg-rust/pull/435#discussion_r1666155211
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -123,9 +122,9 @@ impl NamespaceIdent {
Self::from_vec(iter.into_iter().map(|s| s.to_string()).collect())
}
- /// Returns url encoded format.
- pub fn encode_in_url(&self) -> String {
- encode(&self.as_ref().join("\u{1F}")).to_string()
+ /// Returns a string for used in url.
+ pub fn to_url_string(&self) -> String {
+ self.as_ref().join("\u{001f}")
Review Comment:
We use `001f` to following java's implementation:
https://github.com/apache/iceberg/blob/d55591292cf41db8411ede2ace2d8ba5a0cb726c/core/src/main/java/org/apache/iceberg/rest/RESTUtil.java#L36
It seems that it's a control charactor which is not visible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
