nastra commented on PR #10583: URL: https://github.com/apache/iceberg/pull/10583#issuecomment-2205538061
> > should be good to go once https://github.com/apache/iceberg/pull/10583/files#r1663651011 has been addressed > > Sorry, it's really out of scope of this PR ("Adress IntelliJ Inspection findings"). We're improving the code and the null check is being removed since it wasn't null in the first place, so what prevents us from updating `"Cannot use empty or null partition name:` to `"Cannot use empty partition name:` to also improve the error msg in order to reflect the current state? I don't see see a reason to improve this error msg in a separate PR, hence this can be handled while touching the same code line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
