nastra commented on code in PR #10583:
URL: https://github.com/apache/iceberg/pull/10583#discussion_r1663651011
##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -410,7 +410,7 @@ private void checkAndAddPartitionName(String name, Integer
sourceColumnId) {
}
}
Preconditions.checkArgument(
- name != null && !name.isEmpty(), "Cannot use empty or null partition
name: %s", name);
+ !name.isEmpty(), "Cannot use empty or null partition name: %s",
name);
Review Comment:
this still needs to be addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
