szehon-ho commented on code in PR #10288: URL: https://github.com/apache/iceberg/pull/10288#discussion_r1663127233
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/AnalyzeTableSparkAction.java: ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.actions; + +import java.util.List; +import java.util.Set; +import java.util.UUID; +import java.util.stream.Collectors; +import org.apache.iceberg.GenericBlobMetadata; +import org.apache.iceberg.GenericStatisticsFile; +import org.apache.iceberg.HasTableOperations; +import org.apache.iceberg.Snapshot; +import org.apache.iceberg.StatisticsFile; +import org.apache.iceberg.Table; +import org.apache.iceberg.TableOperations; +import org.apache.iceberg.actions.AnalyzeTable; +import org.apache.iceberg.actions.ImmutableAnalyzeTable; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.io.OutputFile; +import org.apache.iceberg.puffin.Blob; +import org.apache.iceberg.puffin.Puffin; +import org.apache.iceberg.puffin.PuffinWriter; +import org.apache.iceberg.puffin.StandardBlobTypes; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet; +import org.apache.iceberg.spark.JobGroupInfo; +import org.apache.iceberg.types.Types; +import org.apache.spark.sql.SparkSession; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** Computes the statistic of the given columns and stores it as Puffin files. */ +public class AnalyzeTableSparkAction extends BaseSparkAction<AnalyzeTableSparkAction> + implements AnalyzeTable { + + private static final Logger LOG = LoggerFactory.getLogger(AnalyzeTableSparkAction.class); + private static final Set<String> supportedBlobTypes = + ImmutableSet.of(StandardBlobTypes.APACHE_DATASKETCHES_THETA_V1); + + private final Table table; + private Set<String> columns; + private long snapshotId; + + AnalyzeTableSparkAction(SparkSession spark, Table table) { + super(spark); + this.table = table; + Snapshot snapshot = table.currentSnapshot(); + if (snapshot == null) { + LOG.error("Unable to analyze the table since the table has no snapshots"); + throw new RuntimeException("Snapshot id is null"); Review Comment: Nit: update exception message to more reflect error? (like the log message?) ########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/ThetaSketchJavaSerializable.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.actions; + +import java.io.IOException; +import java.io.ObjectInputStream; +import java.io.ObjectOutputStream; +import java.io.Serializable; +import java.nio.ByteBuffer; +import org.apache.datasketches.memory.Memory; +import org.apache.datasketches.theta.CompactSketch; +import org.apache.datasketches.theta.SetOperationBuilder; +import org.apache.datasketches.theta.Sketch; +import org.apache.datasketches.theta.UpdateSketch; + +class ThetaSketchJavaSerializable implements Serializable { + + private Sketch sketch; + + ThetaSketchJavaSerializable() {} + + ThetaSketchJavaSerializable(Sketch sketch) { + this.sketch = sketch; + } + + Sketch getSketch() { + return sketch; + } + + CompactSketch getCompactSketch() { + if (sketch == null) { + return null; + } + + if (sketch instanceof UpdateSketch) { + return sketch.compact(); + } + + return (CompactSketch) sketch; + } + + void update(ByteBuffer value) { + if (sketch == null) { + sketch = UpdateSketch.builder().build(); + } + if (sketch instanceof UpdateSketch) { + ((UpdateSketch) sketch).update(value); + } else { + throw new RuntimeException("update() on read-only sketch"); + } + } + + double getEstimate() { + if (sketch == null) { + return 0.0; + } + return sketch.getEstimate(); + } + + private void writeObject(ObjectOutputStream out) throws IOException { + if (sketch == null) { + out.writeInt(0); + return; + } + byte[] serializedSketchBytes = sketch.compact().toByteArray(); + out.writeInt(serializedSketchBytes.length); + out.write(serializedSketchBytes); + } + + private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException { + int length = in.readInt(); + if (length == 0) { + return; + } + byte[] serializedSketchBytes = new byte[length]; + in.readFully(serializedSketchBytes); + sketch = CompactSketch.wrap(Memory.wrap(serializedSketchBytes)); + } + + static ThetaSketchJavaSerializable updateSketch( + ThetaSketchJavaSerializable sketch, ByteBuffer val) { + sketch.update(val); + return sketch; + } + + static ThetaSketchJavaSerializable combineSketch( + ThetaSketchJavaSerializable sketch1, ThetaSketchJavaSerializable sketch2) { + ThetaSketchJavaSerializable emptySketchWrapped = Review Comment: Nit: can we just inline this in the return value? It doesnt seem to be used elsewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
