hililiwei commented on code in PR #7362:
URL: https://github.com/apache/iceberg/pull/7362#discussion_r1637693841
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -291,6 +291,14 @@ public Builder<T> startSnapshotTimestamp(Long
newStartSnapshotTimestamp) {
return this;
}
+ public Builder<T> endSnapshotTimestamp(Long endSnapshotTimestamp) {
+ if (endSnapshotTimestamp != null) {
+ readOptions.put(
+ FlinkReadOptions.END_SNAPSHOT_TIMESTAMP.key(),
Long.toString(endSnapshotTimestamp));
+ }
+ return this;
Review Comment:
To maintain a consistent style with the previous and subsequent methods
(which don't have empty lines added), especially considering there's a return
statement here, I think we can leave it as it is. Of course, I'm open to
modifying it if needed. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
