pvary commented on code in PR #7362:
URL: https://github.com/apache/iceberg/pull/7362#discussion_r1632737707
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceBoundedSql.java:
##########
@@ -71,6 +75,16 @@ protected List<Row> run(
throws Exception {
String select = String.join(",", sqlSelectedFields);
String optionStr = SqlHelpers.sqlOptionsToString(options);
- return SqlHelpers.sql(getTableEnv(), "select %s from t %s %s", select,
optionStr, sqlFilter);
+ TableResult tableResult =
+ getTableEnv()
+ .executeSql(String.format("select %s from t %s %s", select,
optionStr, sqlFilter));
+ try (CloseableIterator<Row> iter = tableResult.collect()) {
+ return Lists.newArrayList(iter);
+ } catch (Exception e) {
+ // To retrieve the underlying exception information that actually caused
the task failure.
+ // throw (RuntimeException)
+ // e.getCause().getCause().getCause().getCause().getCause().getCause();
Review Comment:
Nit: Did you plan to remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
